You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 2 Next »



  1. Open your web browser and navigate to the issue area of the FOLIO Analytics repository at https://github.com/folio-org/folio-analytics/issues



  2. Click the New issue button to add an issue for the query you will work on, adding the functional area acronym in the title (e.g., ACQ). 
  3.  Use the Milestone drop-down menu to assign this issue to a particular release (e.g., 1.7 Poppy) 
  4.  Create a new fork or navigate to your existing fork of the folio-analytics repository and make sure that fork is up-to-date.
  5. Open your repository (e.g., sbeltaine/folio-analytics), and make sure it is pointing to the master branch on your fork of the repository. If it says “This branch is XX commits behind folio-org:main," click Sync fork to bring your fork up-to-date with folio-org:main.





  6.  When you edit or create a new report or derived table, use the issue number to create a new branch in your GitHub fork of the folio-analytics repository (eg Iss123) so you can tie your branch to the PR and issue. Select the Master branch drop-down list. In the branch where it says "Find or create a branch," add "IssXXX," where XXX is the number for the issue you created earlier. 

       




  7. Create or update the report query or derived table query you wish to contribute to folio-analytics in the appropriate directory on the new IssXXX branch you have created in your own fork of folio-analytics.


CONTINUE HERE


-A pull request pulls in all commits added to a branch


-submit a PR from your fork from that numbered branch; when you go to submit, change the note about the issue number to a description of what your pull request is about, mentioning that it closes issue XXX

-in the same pull request, update runlist.text with the name of the table

-update Changes by Release in the folio-analytics wiki with notes about the table

-add the label “needs reviewer” to the PR



Example of Comments for Submitting a Pull Request


Closes #757


Updated filename for "po_line_vendor_reference_number" to "po_lines_vendor_reference_numbers" to match equivalent LDP table name.

Also updated entry for "po_line_vendor_reference_number" to "po_lines_vendor_reference_numbers" in runlist.txt file for metadb.

Also updated  "--metadb:table po_line_vendor_reference_number" to "--metadb:table po_lines_vendor_reference_numbers" at top of query.


Documented this update on the 1.7 (Poppy) release notes at https://github.com/folio-org/folio-analytics/wiki/Changes-by-Release



  • No labels